siku2 / hass-weatherlink

Home Assistant integration for Davis Instruments' WeatherLink and AirLink
MIT License
26 stars 7 forks source link

Weatherlink Pressure Units #24

Open raf10gh opened 2 years ago

raf10gh commented 2 years ago

Hi Siku2,

I see my pressure is displayed in PSI. I want it in inHg and tried changing in the Unit of Measure drop down to inHg and click Update but it doesn't save the changes.

Pressure

Pressure_psi

I see that under the Weatherlink device it is set to inHg.

Pressure_inHG

Not sure if I'm doing something wrong or if it is a bug.

Thanks

Rick

siku2 commented 2 years ago

The reason for this is that up until recently Hass didn't support switching units like that so this integration included its own system using the integration options.

raf10gh commented 2 years ago

Ok so is there a way to change it to inhG? In the Weatherlink screenshot the pressure units is set to inHg but it still displays in PSI.

raf10gh commented 2 years ago

Disregard I found it.

Thanks

ppetru commented 1 year ago

The reason for this is that up until recently Hass didn't support switching units like that so this integration included its own system using the integration options.

Would you be willing to switch to the home assistant unit conversion system? I might try to help when I find some time.

siku2 commented 1 year ago

Would you be willing to switch to the home assistant unit conversion system? I might try to help when I find some time.

absolutely, I was never a fan of rolling my own in the first place. I was planning to remove it the next time I made any changes to the code.