siku2 / hass-weatherlink

Home Assistant integration for Davis Instruments' WeatherLink and AirLink
MIT License
27 stars 7 forks source link

Refactor Weather entity to use native unit conversions #28

Closed ppetru closed 1 year ago

ppetru commented 1 year ago

Should fix #25

siku2 commented 1 year ago

Do you want to get this in as-is, or is there more to come?

ppetru commented 1 year ago

Just this for now, it makes the warning go away and the code works with HA 2023.1.

I have a half baked attempt at the unit conversion stuff but it's not working yet and not worth blocking on (it's very unpredictable when I get some time to hack on this).

On Mon, Jan 9, 2023, 16:26 Simon @.***> wrote:

Do you want to get this in as-is, or is there more to come?

— Reply to this email directly, view it on GitHub https://github.com/siku2/hass-weatherlink/pull/28#issuecomment-1375905970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA3EI3ZFAJ6CCJVY2QLNRTWRQ3ZPANCNFSM6AAAAAATVCFOMM . You are receiving this because you authored the thread.Message ID: @.***>