search

siku2 / script.service.sponsorblock

Kodi add-on for SponsorBlock
MIT License
124 stars 14 forks source link

merge overlapping segments #19

Closed macearl closed 3 years ago

macearl commented 3 years ago

Merge segments which start and end time are less than 500ms apart.

i think this more a work in progress rather than finished.

I added this to the player listener as i don't really think the API class should merge normally distinct segments into each other, but I am also not sure if this is the best place for it.

I added some comments to a couple of lines, which I am not sure on yet.

macearl commented 3 years ago

whoops, completely missed your commit: https://github.com/siku2/script.service.sponsorblock/commit/e33cf042c3e64eded2315efa7d3dab355e2235bf#

seems like we commited / opened the PR at roughly the same time.

I'll test that tomorrow and see if it works as well, if yes this PR can probably be closed without merging

macearl commented 3 years ago

closing this as another solution for this was implemented in https://github.com/siku2/script.service.sponsorblock/commit/e33cf042c3e64eded2315efa7d3dab355e2235bf