siku2 / script.service.sponsorblock

Kodi add-on for SponsorBlock
MIT License
126 stars 15 forks source link

ignore segments that do not fit into reduce skips setting #31

Closed matejdro closed 2 years ago

matejdro commented 2 years ago

With #30 user can reduce all skips by some amount. However, service starts acting weirdly when skip points are shorter than set reducing amount. At best nothing happens and only "Sponsor skipped" window appears and at worst it will skip backwards until it will reach sponsor again, running into infinite loop.

This PR fixes the issue by filtering and not scheduling any skips that would have been shorter than the reducing skip setting.

siku2 commented 2 years ago

Great implementation!