search

siku2 / script.service.sponsorblock

Kodi add-on for SponsorBlock
MIT License
124 stars 14 forks source link

Segment at the very beginning not skipped #41

Closed ape364 closed 1 year ago

ape364 commented 1 year ago

38

bugfix: search next segment after 0 seconds when ad segment placed at the very beginning of the video

siku2 commented 1 year ago

Now you just need to call this function with playback_started = True in onPlayBackStarted, otherwise this doesn't actually do anything. If possible, please also test this locally. The roundtrip for testing it after the release is going to take a lot more time, so if it doesn't work it's gonna be a bit of a waste.

ape364 commented 1 year ago

Now you just need to call this function with playback_started = True in onPlayBackStarted, otherwise this doesn't actually do anything. If possible, please also test this locally. The roundtrip for testing it after the release is going to take a lot more time, so if it doesn't work it's gonna be a bit of a waste.

Oops! :) I don't know how to test it proper locally, so I just edited player_listener.py on my RPi and forgot to make function call changes at the repository. Now fixed

siku2 commented 1 year ago

Looking good. Did you make sure everything works as expected?

ape364 commented 1 year ago

Looking good. Did you make sure everything works as expected?

Yep, I've checked on some videos from the same channel as in the 1st post.

siku2 commented 1 year ago

Yep, I've checked on some videos from the same channel as in the 1st post.

Thanks, just wanted to be sure as I don't have the ability to test it myself ATM