siku2 / script.service.sponsorblock

Kodi add-on for SponsorBlock
MIT License
124 stars 14 forks source link

feat: add minimum duration setting #48

Closed SethFalco closed 1 year ago

SethFalco commented 1 year ago

Introduced the setting, minimum_duration_ms.

Both the name and help text are just tweaks from the original strings in the SponsorBlock extension. (See image!)

image

Tested this with Invidious and the setting works fine! However, I've never actually had the problem described in #36. In theory, it should be resolved though.

Related

siku2 commented 1 year ago

Alternatively, you can merge that one first

woops, I guess we're doing it that way because I didn't notice this one first

SethFalco commented 1 year ago

woops, I guess we're doing it that way because I didn't notice this one first

No problem! I actually didn't think it'd matter since I thought GitHub would offer to rebase it, but I guess GitHub doesn't account for that in its default merge strategy or conflict check.

Literally rebased it locally with no conflicts and pushed though, all good. :+1: