Add German localisation

siku2 / script.service.sponsorblock

Kodi add-on for SponsorBlock

MIT License

126 stars 16 forks source link

Add German localisation #9

Closed gitlocalize-app[bot] closed 4 years ago

gitlocalize-app[bot] commented 4 years ago

See review request on GitLocalize

siku2 commented 4 years ago

@NettoHikari I have no idea if GitLocalize sent you a notification (it didn't send me one) so I'm just pinging you here again to make sure. Thank you very much for taking the time to translate the strings! :heart:

I made some minor adjustments:

Changed "Überspringen rückgängig machen" to "Zurück" because this string needs to be short. It might not be perfectly accurate but I feel it gets the point across.
Changed "Mit Kommata unterteilte [...]" to "Komma getrennte [...]". Quite honestly I only did this because I thought "Kommata" was a typo :sweat:. Turns out it's not so I look rather dumb right now but I feel like my version doesn't read any worse.

If you have a problem with my changes don't hesitate to let me know, I trust you to make the right call.

NettoHikari commented 4 years ago

Hey!

You're welcome. At first, I was out and about to create an issue on GitHub, because the addon didn't work for me at first. After I enabled debug logs, it suddenly started working, so I decided to take a couple minutes and translate the strings real quick.

Regarding your questions:

"Zurück" should be fine
"Durch Kommata getrennte [...]" should be better. Just "Komma getrennte [...]" is not correct, unfortunately.

Thank you very much for developing this add-on. I could also do a Japanese translation as well.

Greetings from Germany

siku2 commented 4 years ago

@NettoHikari Thanks for the correction, I adjusted it in a1ac5eb950b11803635f7174e94eacaab6784040.

If you have the time, could you take a look at the addon.xml file too? It also contains a few strings that need to be localized. GitLocalize sadly doesn't detect them and I haven't found a good way to handle those yet. Only the summary, description, and disclaimer tags need to be translated.

I could also do a Japanese translation as well.

I would love to see that! I don't know if you can add it as a language on GitLocalize yourself - please give it a shot because I would really like to know. Otherwise just tell me and I'll add it for you.

NettoHikari commented 4 years ago

Sorry, I actually didn't notice you answered. :) I can check that later!