search

sil-quirk / sil-q

Other
210 stars 32 forks source link

Resolved crash when clicking on a Sil-Q X11 window #56

Closed nlg closed 3 years ago

nlg commented 3 years ago

XChangeProperty:format specifies whether the data should be viewed as 8,16,32 bit. The data in this case is an Atom, which is a typedef for unsigned long on x64 (64bits). This causes a crash, since 64 bit is not allowed. While this is confusing, 32 bit should be used even though the data itself might be 64 bit.

nlg commented 3 years ago

I discovered a crash on Linux/X11 after compiling HEAD 92e6fb08c872315b9436a2053630ad9e825dcefa Please review my updates.

sil-quirk commented 3 years ago

Having reviewed, I'm willing to take the chance that this breaks 16-bit systems.