sil-quirk / sil-q

Other
210 stars 32 forks source link

fix build guide/makefile/.gitattribute for windows #65

Closed MT-Arnoldussen closed 3 years ago

MT-Arnoldussen commented 3 years ago

I had some issues trying to build Sil-Q on Windows using the instructions found in README.md.

With some help I was able to narrow down my issues to the following:

This commit fixes these issues.

Especially re: the last issue, I can understand if these parameters serve some purpose unknown to me. I am simply sharing what made the build work for me.

sil-quirk commented 3 years ago

Removing "-F pe-i386" breaks my build, I am afraid. Message is "sil.res: file not recognized: file format not recognized".

I can safely remove the "-e _mainCRTStartup" and am happy to incorporate this and the other changes; I am not clear why not specifying the BFD format makes your build work. What is your default target if you type windres --help and look at the first of the supported targets?

MT-Arnoldussen commented 3 years ago

My defaultt target is pe-i386, so I double checked and it turns out neither of the two parameters actually break my build... Sorry for the confusion.

I distinctly remember both of them changing the build error I got / making the build fail later, which made me assume they were necessary steps in fixing my problem. But it looks like the only real issues were the Cygwin version and the line endings.

I added both the parameters back.