search

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.65k stars 98 forks source link

Feat unicode softhyphen support #1935

Closed Omikhleia closed 9 months ago

Omikhleia commented 9 months ago

Closes #1930

The proposal described there, with a test.

alerque commented 9 months ago

Any thoughts on a release target for this? v0.14.14? v0.15.0? Let it simmer?

Omikhleia commented 9 months ago

@alerque

Any thoughts on a release target for this? v0.14.14? v0.15.0? Let it simmer?

If deemed acceptable, both #1935 and #1918 (EDIT) need proper documentation and could eventually go in 0.15 -- There's no real urge for them, your call depending on your release schedule!

Omikhleia commented 9 months ago

Removed the "Draft" by the way. Looking at the expected results, I realized we could do better (avoiding the string to be split in multiple unshaped tokens when soft hyphens are ignored = so ligatures will work then) and I rebased my earlier version.

alerque commented 9 months ago

I definitely approve of the direction and as much of the implementation as I see, so document away. Since it isn't a breaking change I'm totally fine with putting it in the next minor release (semver patch level). I'll keep making those occasionally until such a time as v0.15.0 is ready. That still has a bit of baking to do but I'm hoping it won't be too much longer.

Omikhleia commented 9 months ago

Documentation added in the manual ch. 8, "Hyphenation" section, as a note.