search

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.65k stars 98 forks source link

Touchup Mac builds and Nix flake #1941

Closed alerque closed 9 months ago

alerque commented 9 months ago

Closes #1879

doronbehar commented 9 months ago

Sounds good to me. Great!

On 20 December 2023 22:25:49 GMT+02:00, Caleb Maclennan @.***> wrote:

@alerque commented on this pull request.

@@ -118,8 +118,6 @@ in stdenv.mkDerivation (finalAttrs: {

postPatch = '' patchShebangs build-aux/*.sh build-aux/git-version-gen

  • '' + lib.optionalString stdenv.isDarwin ''

  • sed -i -e @.*** AppKit;|#import <AppKit/AppKit.h>|' src/macfonts.m '';

    NIX_LDFLAGS = lib.optionalString stdenv.isDarwin "-framework AppKit";

Thank for the options. I'll look into them, some now some later.

For the moment I think we'll move ahead with the bits I'm sure about, then when v0.15.0 actually drops and we update the official Nix pkgs repo with the stable release we can test whether than is needed or not. If not we can then remove it from the Flake too.

-- Reply to this email directly or view it on GitHub: https://github.com/sile-typesetter/sile/pull/1941#discussion_r1433153869 You are receiving this because you commented.

Message ID: @.***>