search

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.62k stars 97 forks source link

Fix polish compound hyphen rule #1962

Closed Omikhleia closed 5 months ago

Omikhleia commented 5 months ago

Closes #1960

The sheer superiority of SILE over other typesetting systems (add lots of smiley faces).

Omikhleia commented 5 months ago

Lol.

image

Good on first occurrence (lines 2-3), but bad of on subsequent one (lines 4-5). Back to the working bench.

Omikhleia commented 5 months ago

Good on first occurrence (lines 2-3), but bad of on subsequent one (lines 4-5). Back to the working bench.

Got it. I never understood fully the ICU stuff (and when debugging, it seems to show some weird re-entrance). Anyhow, ICU will also mark word boundaries as (line) breaks, and we get a penalty (0) in those case. Here just after a "special" discretionary, we need to cancel it....

alerque commented 5 months ago

FreeBSD test is failing because 12.x is EOL now. I fixed that and added tests for 14.x to the develop branch work along with appropriate dependency updates. I may get a minute to backport that, but even if not I think we could safely ignore the FreeBSD testing for this and any other of the v0.14.x releases.

alerque commented 5 months ago

Hopefully my rehash of the test case captured the ethos of what was being tested here with 120 less lines of debug data and long lines of prose to parse when reviewing test changes later.