Fix Catalan hyphenations at geminated L

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine

https://sile-typesetter.org

MIT License

1.65k stars 98 forks source link

Fix Catalan hyphenations at geminated L #1964

Closed Omikhleia closed 8 months ago

Omikhleia commented 8 months ago

Closes #1961

Instal·lem SILE per a la llengua catalana!

And we are in advance, but happy Dia del Punt Volat on January 24 to our Catalan friends.

Omikhleia commented 8 months ago

I think my only concern with this and the other PR is the size of the test case

I amended my test commit to make it smaller and on A7

Would that be sufficient?

Line 1 and 3 show hyphenations in the segments resp. after and before the geminated L (to check replacement worked)
Line 2 shows hyphenation at the segment with the geminated L (to check prebreak worked)
Sequence repeated with the precomposed characters.

alerque commented 8 months ago

If I understand the test correctly the fixup commit I just sent should accomplish the same thing, save about 30 lines of diffs, and also be a lot easier to visually inspect later to see if the proper thing is still being tested. Can you give that a check to make sure I understood it correctly?

Omikhleia commented 8 months ago

Can you give that a check to make sure I understood it correctly?

Looks good to me!