nnodes contain the language in several fields - Githubissues

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine

https://sile-typesetter.org

MIT License

1.65k stars 98 forks source link

nnodes contain the language in several fields #1965

Open Omikhleia opened 8 months ago

Omikhleia commented 8 months ago

The language is in node.language (tracked back to shaper:formNnode) and in node.options.language It needs to be in the options (for createNnodes etc.). We however have two possibilities and we use one or the other at different places. That's code smell -> I would suggest a dedicated refactoring issue...

_Originally posted by @Omikhleia in https://github.com/sile-typesetter/sile/pull/1964#discussion_r1460859798_