search

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.61k stars 97 forks source link

Only call 'noindent' if language is English in book commands #1991

Open jodros opened 5 months ago

jodros commented 5 months ago

Since it's a English feature it shouldn't be called if document.language isn't English as well...

Omikhleia commented 5 months ago

The more relevant point is that there are a handful of languages that specifically eschew this:

And I might be mistaken, but usage depends on conventions that are not strictly language-specific (i.e. there could be a language-specific default, but it would likely need to be something the user can configure) (As an aside note, in a styling paradigm such as your @jodros, or mine, this could be left to a styling decision)

jodros commented 5 months ago

I'm actually refactoring that right now and am hopeful we'll have a better place to "hang this hat" soon. I'll leave this PR around as a reminder of the issue and we'll update it to to the right thing when there is a sensible way to do so.

Right, things aren't as simple as they look sometimes...

(As an aside note, in a styling paradigm such as your @jodros, or mine, this could be left to a styling decision)

yeah, I thought about that, and I really think that we should discuss further the implementation of a basic styling paradigm in SILE, this is essencial for typesetting!

Omikhleia commented 2 months ago

An interesting discussion on the topic: https://tex.stackexchange.com/a/39232

(The whole discussion mentions typographers such as Bringhurst, Tschichold; and the French Imprimerie Nationale -- all sorts of lectures I personally like)

There could be a language-specific default, thus... --> Linking to #2017 as we might need some other language-specific customization there too.