sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.61k stars 97 forks source link

Bibliography package improvements on BibTeX syntax #2048

Closed Omikhleia closed 1 week ago

Omikhleia commented 3 weeks ago

Branch for some bibliography package fixes and improvements

Let's start gently and see where / how it goes.

Closes #2021 Closes #2051 Closes #2050 Closes #1860

Omikhleia commented 2 weeks ago

So this first PR is focused low-hanging fruits, regarding the support of more Bib(La)TeX syntax elements without breaking existing working behavior yet:

Later, I'll want to refactor some of the code and reorganize the files differently, in order to tackle properly with issues that will change the output, but this first step should be a decent base for the work to come, and it remains minimally readable (which would become harder after reshuffling some of the logic in different files).

Ready for review.

alerque commented 2 weeks ago

Just a side note on the Lua style thing.... when you see me push those kind of fixups just know there is absolutely no need to to make an effort to preserve them. If you happen to have other work in a commit or branch and my style fixups are causing rebase conflicts or anything like that just keep the work you have and blow the code formatting fixes away. They are 100% automated and next to zero work to redo at any point, so don't stress if they are causing conflicts. And don't stress about getting the formatting right while writing code either, whatever is easier to write you can write, the auto formatter can take it from any Lua code that runs.