search

sile-typesetter / sile

The SILE Typesetter — Simon’s Improved Layout Engine
https://sile-typesetter.org
MIT License
1.67k stars 99 forks source link

Test and fix verbatim line handling #2129

Closed alerque closed 3 weeks ago

alerque commented 1 month ago

Closes #2128

...as of posting all I have is a test that shows its broken.

coveralls commented 1 month ago

Coverage Status

coverage: 57.928% (+3.7%) from 54.19% when pulling 73cd72ce18451e51b9e4c1674b335fe59b871021 on verbatim-lines into 21bcc5c0f7e3ea335833de7f3cca21f543a71097 on master.

Omikhleia commented 1 month ago

Would this meet the expectations? (your test here + an additional check + the autodoc blurb from the manual cited in the issue):

image

If so, I can try to make it neat, perhaps this week-end. (Using a hack currently, but the path from that point seems to be the way to go, if it doesn't break anything else...)

alerque commented 1 month ago

Yes that output looks right. The final test should have as little noise as possible but testing the double line scenario makes sense. Feel Free to push WIP to this branch or PR to target it.

My dev time is total chaos right now. Our son was born last week but had complications and is in the NICU for a while. I'm fiddling with FOSS here and there in waiting rooms to keep time moving.

Omikhleia commented 1 month ago

Our son was born last week but had complications and is in the NICU for a while.

I'm sincerely sorry to hear about the complications. I can't imagine how hard this must be for you and your wife. I’m keeping you all, and your baby in my thoughts and hoping for a smooth recovery.

Feel Free to push WIP to this branch (...)

Just pushed a few commits on top of yours (the extra 2-line test, fixes to the verbatim/autodoc packages, and the crux of the issue in the typesetter). One test fails (bug-132) -- and it's actually a verbatim-related test, so that seems expected (I just looked at it very quicky, it does seem ok and it's likely caused by the parskip/baselineskip adjusments). This remains an empirical WIP, though, I'll go on checking the changes and possibly backport them to my own environments to see how they behave here (the user guides for resilient.sile and markdown.sile have plenty of verbatim-like blocks too, so I'm eager to check how these changes would behave in that context...). But for now (3 AM lol), I need some sleep :p

alerque commented 3 weeks ago

Our son was born last week but had complications and is in the NICU for a while.

I'm sincerely sorry to hear about the complications. I can't imagine how hard this must be for you and your wife. I’m keeping you all, and your baby in my thoughts and hoping for a smooth recovery.

Thank you. We and our son have had a rough go of it. His heart stopped during birth and he ended up with stage 2 hypoxic-ischemic encephalopathy, spent 10 days in ICU, and is still under close neurological monitoring. Physically he's recovering fairly well although brain activity on an EEG is still abnormal. But we're glad he's home with us now and we're praying for his eventual full recovery.