sile / jsone

Erlang JSON library
MIT License
291 stars 72 forks source link

build error on 0TP 21: Erlang:get_stracktrace is deprecated #33

Closed benoitc closed 6 years ago

benoitc commented 6 years ago

When trying to build sone on OTP 21 you get the the following errors:

_build/default/lib/jsone/src/jsone.erl:294: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
_build/default/lib/jsone/src/jsone.erl:343: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
benoitc commented 6 years ago

I added a PULL REQUEST to it. Another solution would be just removing the stack trace handling which can be an issue in some cases where you need to ensure no sensitive data will be raised. Thoughts?

benoitc commented 6 years ago

you can reproduce it by building barrel .

benoitc commented 6 years ago

my bad, so the rebar.lock was keeping the old dependency (1.4.3). Using 1.4.6 worked. I will create a new ticket for using OTP_RELEASE