search

sile / jsone

Erlang JSON library
MIT License
291 stars 72 forks source link

Fix incorrect regex in platform_define #56

Closed jesperes closed 3 years ago

jesperes commented 3 years ago

This broken regex will match against "17" anywhere in the OTP version string, and so will define NO_DIALYZER_SPEC also for newer OTP versions, e.g. 22.3.4.17.

codecov-io commented 3 years ago

Codecov Report

Merging #56 (489a990) into master (b5a0c42) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files           3        3           
  Lines         283      283           
=======================================
  Hits          255      255           
  Misses         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5a0c42...489a990. Read the comment docs.