search

sile / libflate

A Rust implementation of DEFLATE algorithm and related formats (ZLIB, GZIP)
https://docs.rs/libflate
MIT License
178 stars 35 forks source link

Remove byteorder-dependency #42

Closed lukaslueg closed 5 years ago

lukaslueg commented 5 years ago

This removes this byteorder-dependency which is not strictly needed since Rust 1.32. Due to a single use of TryInto (which could be avoided) the minimum Rust version is now 1.34.2

As one can see, there is a lot more manual reading/writing involved. I think the change is worth losing a dependency, though.

Fixes #40

codecov-io commented 5 years ago

Codecov Report

Merging #42 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   91.34%   91.42%   +0.07%     
==========================================
  Files          14       14              
  Lines        1283     1294      +11     
==========================================
+ Hits         1172     1183      +11     
  Misses        111      111
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) :arrow_up:
src/deflate/encode.rs 96.62% <100%> (+0.02%) :arrow_up:
src/non_blocking/zlib.rs 95.06% <100%> (+0.25%) :arrow_up:
src/non_blocking/deflate/decode.rs 86.39% <100%> (+0.24%) :arrow_up:
src/bit.rs 94.21% <100%> (+0.09%) :arrow_up:
src/util.rs 91.17% <0%> (+0.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22d1090...ec74ff4. Read the comment docs.

lukaslueg commented 5 years ago

Took liberty for force-push the change, getting rid of TryInto. Notice that there does not seem to be a test that actually verifies modification_time.