search

sile / scalable_cuckoo_filter

A variant of Cuckoo Filter whose size automatically scales as necessary
MIT License
17 stars 7 forks source link

Can't clone ScalableCuckooFilter<str> #10

Closed jeffutter closed 6 months ago

jeffutter commented 6 months ago

If I have a ScalableCuckooFilter into which I can insert &str's it makes the type of my filter ScalableCuckooFilter<str> which can then not be cloned. I'm not exactly sure how to fix this, but it seems like a type system issue since the filter doesn't actually take ownership of the str data.

I wonder if Clone cloud be manually implemented for ScalableCuckooFilter or if there's a different way to express the type of the input data.

jeffutter commented 6 months ago

I submitted a PR #11 that seems to address this. I'm open to better ways to handle it though.