search

sile / sloggers

A Rust library which provides frequently used slog loggers and convenient functions
MIT License
37 stars 18 forks source link

Added KVFilter, Atomicswitch start #13

Closed przygienda closed 6 years ago

przygienda commented 6 years ago

per previous pull added KVFilter, reordered things for performance from experience here (you want KVFilter & LevelFilter before Async)

Atomicswitch integrated, control will still need exposure, thinking about it.

sile commented 6 years ago

I think that it is better to divide the feature related to AtomicSwitch into a different PR. KVFilter related code seems has no problem, so it will be possible to be merged sooner if it is separated from the AtomicSwitch code.

przygienda commented 6 years ago

removed atomicswitch for this PR ...

sile commented 6 years ago

Thanks, but some AtomicSwitch related code are remaining (e.g., https://github.com/sile/sloggers/pull/13/files#diff-6d00071c5cb83f348e478f2a87d45999R122 ).

przygienda commented 6 years ago

sorry, probably forgot to push ...

sile commented 6 years ago

Thanks! I will merge this PR.