Feature request: conditional dependency on gzip (libflate)

sile / sloggers

A Rust library which provides frequently used slog loggers and convenient functions

MIT License

37 stars 18 forks source link

Feature request: conditional dependency on gzip (libflate) #24

Closed koba-e964 closed 4 years ago

koba-e964 commented 4 years ago

It looks like libflate is used only if FileAppender::compress is used. Maybe it's a possible idea to make this feature optional and allow users of this crate to opt-out dependency on libflate?

koba-e964 commented 4 years ago

I mean this kind of change: https://github.com/sile/sloggers/commit/15c18c51853b37effc96feabe4c309ac25004672 (not yet confirmed to work properly, though)

sile commented 4 years ago

Sounds good. If you can create a PR based on https://github.com/sile/sloggers/commit/15c18c51853b37effc96feabe4c309ac25004672, I would like to merge and review it.

koba-e964 commented 4 years ago

PR sent: https://github.com/sile/sloggers/pull/25