adds process id and kvfilter

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 911887549

28 of 107 (26.17%) changed or added relevant lines in 4 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.5%) to 48.121%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/terminal.rs	8	14	57.14%
src/types.rs	3	13	23.08%
src/file.rs	17	33	51.52%
src/misc.rs	0	47	0.0%
<!--	Total:	28	107	26.17%	-->

Files with Coverage Reduction	New Missed Lines	%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.5.1/src/context.rs	1	60.32%
src/file.rs	2	66.67%
<!--	Total:	3	-->

Totals
Change from base Build 889664888:	-0.5%
Covered Lines:	1626
Relevant Lines:	3379

💛 - Coveralls

sile commented 3 years ago

Could you tell me the state of this PR? Is it ready for review?

przygienda commented 3 years ago

should be. I merged with newest stuff, tests pass

On Sun, Jun 13, 2021 at 3:08 AM Takeru Ohta @.***> wrote:

Could you tell me the state of this PR? Is it ready for review?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sile/sloggers/pull/42#issuecomment-860133683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANDICYCTEWG4BDRJSQ2MTDTSQAIDANCNFSM46F7UCDQ .

sile commented 3 years ago

I'll take a more detailed look at this PR when I have time (I'll busy this week, so that may become next week or later).

sile commented 3 years ago

(I'm waiting for the CI failure to be resolved to restart PR review)

sile commented 9 months ago

Let me close this PR as there have been no activities for a long time.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 911887549

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

28 of 107 (26.17%) changed or added relevant lines in 4 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.5%) to 48.121%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/terminal.rs	8	14	57.14%
src/types.rs	3	13	23.08%
src/file.rs	17	33	51.52%
src/misc.rs	0	47	0.0%
<!--	Total:	28	107	26.17%	-->

Files with Coverage Reduction	New Missed Lines	%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/crossbeam-channel-0.5.1/src/context.rs	1	60.32%
src/file.rs	2	66.67%
<!--	Total:	3	-->

Totals
Change from base Build 889664888:	-0.5%
Covered Lines:	1626
Relevant Lines:	3379

sile / sloggers