Closed macladson closed 2 years ago
Thank you for your PR! I'll review it tomorrow.
BTW, though the CI / Coverage
failed, it seems not relevant to the changes in this PR. So you can ignore that (I'll investigate the cause later).
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/file.rs | 3 | 10 | 30.0% | ||
src/permissions.rs | 0 | 7 | 0.0% | ||
<!-- | Total: | 3 | 17 | 17.65% | --> |
Totals | |
---|---|
Change from base Build 1132511506: | -0.4% |
Covered Lines: | 1621 |
Relevant Lines: | 3301 |
Thank you for the quick review and merge!
Resolves #17
This PR adds a new method to
FileLoggerBuilder
which restricts log file permissions such that they are only readable by the file owner. This corresponds to:600
on Unix systems.600
) on Windows systems.This is done specifically as a restriction rather than setting an arbitrary umask to ensure it worked across both Unix and Windows platforms.