search

sile / sloggers

A Rust library which provides frequently used slog loggers and convenient functions
MIT License
37 stars 18 forks source link

Add source_location parameter #6

Closed dvtomas closed 6 years ago

dvtomas commented 6 years ago

This is my first pull request ever, so I hope I'm doing it right :)

This PR adds a new option for both the file and terminal logger configs, "source_location", which can either be none or module_and_line, being module_and_line by default to maintain backwards compatibility.

The intent is to add the possibility to remove source location logging, which I personally prefer to be off in production.

Along the way I've added comments to example config files and removed some doctest warnings.

dvtomas commented 6 years ago

There seems to be some problems with Travis (rust installation fails?), it will probably be necessary to request Travis to retry somehow?

sile commented 6 years ago

LGTM. Thanks! The failed travis jobs were fixed after re-execution.