search

silentDjay / Mapstery

A geography game inspired by my long history of spending hours on end staring at maps
http://silentdjay.github.io/Mapstery/
6 stars 3 forks source link

Western Sahara isn't recognized #19

Closed olets closed 6 years ago

olets commented 6 years ago

Clicking on Western Sahara gives "you clicked on unclaimed territory"

silentDjay commented 6 years ago

Hey Henry (@olets)! Thanks for your feedback!

You've hit upon an interesting Mapstery problem that I've documented in a separate issue (and just updated to include Western Sahara 👍 ). The Google maps API does not return any country data for territory that it deems disputed (some interesting hits here).

In Mapstery, the list from which I grab the target country does not come from google, so while you were asked to click on Western Sahara, you can't actually do so.

Still looking for an elegant solution; I suppose I could reject any target countries from the initial list that comprise a significant area of disputed territory, or I could manually generate a country match based on lat/lng coordinates when google returns no country data - any suggestions?

Cheers, Happy New Year, and enjoy the snow today! Hope to see you around!

olets commented 6 years ago

Hey Jeremy! Missed this 😜 cool glad to know you know why it's happening. Happy New Year and yeah hope to see you around!