search

silentbicycle / greatest

A C testing library in 1 file. No dependencies, no dynamic allocation. ISC licensed.
ISC License
1.48k stars 108 forks source link

Fix 6 missing dependencies in Makefile #98

Closed vemakereporter closed 5 years ago

vemakereporter commented 5 years ago

Hi, I've fixed 6 dependencies missing reported. Those issues can cause incorrect results when greatest is incrementally built. For example, any changes in "greatest.h" will not cause "example_cpp" to be rebuilt, which is incorrect. Line 45 and 46 in the original Makefile did not work. Makefile and "greatest.h" were not specified successfully as the prerequisites of *.o. I've tested it on my computer, the fixed version worked as expected. Looking forward to your confirmation.

Thanks Vemake

silentbicycle commented 5 years ago

Thanks!

This needs to be targeted against the develop branch -- please see the note at the beginning of CONTRIBUTING.md.

The changes look pretty straightforward, once it's re-targeted and I've tested it, it should be incorporated into the next release (1.5.0).

vemakereporter commented 5 years ago

@silentbicycle I have submitted this PR to develop branch. Could you please confirm it as soon as possible? https://github.com/silentbicycle/greatest/pull/99

silentbicycle commented 5 years ago

This is a personal-time project for me, and I work on it as time allows. I'll probably get to it this weekend.

vemakereporter commented 5 years ago

@silentbicycle Okay, thank you. Looking forward to your confirmation.

silentbicycle commented 5 years ago

Closing this, because #99 replaces this, and was merged.