silentsignal / burp-piper

Piper Burp Suite Extender plugin
https://blog.silentsignal.eu/2020/03/27/unix-style-approach-to-web-application-testing/
GNU General Public License v3.0
113 stars 12 forks source link

Uncaught exception for broken pipes #6

Closed dnet closed 4 years ago

dnet commented 4 years ago

When a CommandInvocation encounters a broken pipe, an exception is thrown which is currently not caught. For example if a MessageMatch tries to feed the message into file(1), after matching magic numbers right at the beginning of the file, file(1) exits with the result while Piper still tries to feed the rest of the message. In this case the whole Piper context menu entry is missing since the uncaught exception fell right through the whole context menu factory.

This exception should be handled just by ignoring it, maybe issuing a warning to the error output if developer mode is on.