search

silentzco / statamic-akismet

4 stars 2 forks source link

Can't update statamic after updating Akismet #26

Closed twd3 closed 3 years ago

twd3 commented 3 years ago

Just tried updating Statamic to 3.0.38 and couldn't because of this error:

PHP Fatal error:  Access level to Silentz\Akismet\ServiceProvider::bootActions() must be protected (as in class Statamic\Providers\AddonServiceProvider) or weaker in C:\_statamic\v-3\vendor\silentz\akismet\src\ServiceProvider.php on line 58In ServiceProvider.php line 58:
  Access level to Silentz\Akismet\ServiceProvider::bootActions() must be protected (as in class Statamic\Providers\Ad
  donServiceProvider) or weaker
Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255
twd3 commented 3 years ago

And I should say this broke the frontend and CP. It was working after just updating Akismet to 3.0.1. But then when I attempted to update Statamic to 3.0.38 after updating Akismet I got the error above and can't access the site. Never pushed changes so only local busted (learning lol).

twd3 commented 3 years ago

image

edalzell commented 3 years ago

Fixed in https://github.com/silentzco/statamic-akismet/commit/e6250111cc5a236b20219d3934bc2b7fb1111b2f