Page Settings won't close on open (V3)

[GetLikha]

Whenever I open page settings, I can't close it, either using the X, Cancel or Ok button I can't recall if I already opened this because I swear I did

[GetLikha]

I also have some suggestions for Site Settings and Page Settings It's confusing because site settings and page settings has similar settings like language, favicon, social media sharing and HTML head

Maybe instead site settings can contain just the Website Name, Website Language, favicon and head And for page settings it's title, description, and social network sharing?

Because if I put code in the of site settings, I'm not sure if it'll also apply for page settings, because it doesn't show there. So maybe either change the customization for page and site settings or make site settings work like symbols? Just a thought \:)

[lexoyo]

Hello @GetLikha Thank you for this bug report, I found and fix this bug: https://github.com/silexlabs/Silex/commit/1bb94a5304e38699ead0fe1405bad1a5b71aeec0#diff-829a43fd501ecd4effd94d573e70de7881aa94b1fac66f50f177102b32177ccbL49 Also made the head code editor way better Would you please confirm the fix works for you?

[GetLikha]

Hey there! I just checked on version 106, it still doesn't work. I'll try on different devices, but yeah

---- On Tue, 22 Aug 2023 14:14:36 -0300 Alex Hoyau @.***> wrote ---

Hello https://github.com/GetLikha Thank you for this bug report, I found and fix this bug: https://github.com/silexlabs/Silex/commit/1bb94a5304e38699ead0fe1405bad1a5b71aeec0#diff-829a43fd501ecd4effd94d573e70de7881aa94b1fac66f50f177102b32177ccbL49 Also made the head code editor way better Would you please confirm the fix works for you? — Reply to this email directly, https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688606903, or https://github.com/notifications/unsubscribe-auth/A7P6LYC347IDY55DYLI6N73XWTSHZANCNFSM6AAAAAA3RBZS5A. You are receiving this because you were mentioned.

[lexoyo]

Oh that's surprising I'll re-check tomorrow Did you make sure to empty the browser cache?

On August 22, 2023 8:40:28 PM GMT+02:00, Likha Studios @.***> wrote:

Hey there! I just checked on version 106, it still doesn't work. I'll try on different devices, but yeah

---- On Tue, 22 Aug 2023 14:14:36 -0300 Alex Hoyau @.***> wrote ---

Hello https://github.com/GetLikha Thank you for this bug report, I found and fix this bug: https://github.com/silexlabs/Silex/commit/1bb94a5304e38699ead0fe1405bad1a5b71aeec0#diff-829a43fd501ecd4effd94d573e70de7881aa94b1fac66f50f177102b32177ccbL49 Also made the head code editor way better Would you please confirm the fix works for you? — Reply to this email directly, https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688606903, or https://github.com/notifications/unsubscribe-auth/A7P6LYC347IDY55DYLI6N73XWTSHZANCNFSM6AAAAAA3RBZS5A. You are receiving this because you were mentioned.

-- Reply to this email directly or view it on GitHub: https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688727173 You are receiving this because you commented.

Message ID: @.***>

[GetLikha]

I cleared my cache, that was the problem  Page settings works now!

I also love what you did with the head code. Just to confirm, if I add something in the head code for site settings, it'll be applied to all pages? Or? Just want to confirm for docs and other stuff, while learning how to use v3 myself :D.

---- On Tue, 22 Aug 2023 17:43:25 -0300 Alex Hoyau @.***> wrote ---

Oh that's surprising I'll re-check tomorrow Did you make sure to empty the browser cache?

On August 22, 2023 8:40:28 PM GMT+02:00, Likha Studios @.***> wrote:

Hey there! I just checked on version 106, it still doesn't work. I'll try on different devices, but yeah

---- On Tue, 22 Aug 2023 14:14:36 -0300 Alex Hoyau @.***> wrote ---

Hello https://github.com/GetLikha Thank you for this bug report, I found and fix this bug: https://github.com/silexlabs/Silex/commit/1bb94a5304e38699ead0fe1405bad1a5b71aeec0#diff-829a43fd501ecd4effd94d573e70de7881aa94b1fac66f50f177102b32177ccbL49 Also made the head code editor way better Would you please confirm the fix works for you? — Reply to this email directly, https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688606903, or https://github.com/notifications/unsubscribe-auth/A7P6LYC347IDY55DYLI6N73XWTSHZANCNFSM6AAAAAA3RBZS5A. You are receiving this because you were mentioned.

-- Reply to this email directly or view it on GitHub: https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688727173 You are receiving this because you commented.

Message ID: @.***> — Reply to this email directly, https://github.com/silexlabs/Silex/issues/1533#issuecomment-1688906052, or https://github.com/notifications/unsubscribe-auth/A7P6LYFMWPXLCRX77GJHAGTXWUKW3ANCNFSM6AAAAAA3RBZS5A. You are receiving this because you were mentioned.

[lexoyo]

Great !. The head code in the settings is applied on all pages yes :) Feel free to ask Have a nice day