npm dependencies versions

silexlabs / unifile

Unified access to cloud storage services through a simple web API.

https://silexlabs.github.io/unifile/

MIT License

144 stars 32 forks source link

npm dependencies versions #112

Closed lexoyo closed 7 years ago

lexoyo commented 7 years ago

We shiould use an exact version for our modules in package.json I just had a module breaking my build

JbIPS commented 7 years ago

Which one? I'm not very fond of fixed version but maybe we could ship a package-lock.json file with our releases.

lexoyo commented 7 years ago

Which one?

Mime, see this commit https://github.com/silexlabs/unifile/commit/8ec996bf33653af2d99b760d5455abf6dacbbb1e

I'm not very fond of fixed version but maybe we could ship a package-lock.json file with our releases.

👍

JbIPS commented 7 years ago

Something weird happened. I'm the one who installed a new major on mime on commit f942a4769efea214f702e8bcb995d053279cde6. I missed Dropbox and since it's not tested enough, it slipped through.

Why did I failed.on your hand and not on CI...I've no idea

JbIPS commented 7 years ago

Closing it since it looks like the problem came from an hazardous merge rather than a npm dependency