silexlabs / unifile

Unified access to cloud storage services through a simple web API.
https://silexlabs.github.io/unifile/
MIT License
144 stars 32 forks source link

Switch FTP client #136

Closed JbIPS closed 6 years ago

JbIPS commented 6 years ago

Tests looks good but UT still fail due to https://github.com/sergi/parse-listing/issues/13.

Waiting for a response before merging

lexoyo commented 6 years ago

Cool! It looks like @trs thinks it's a bug in ftp-srv (https://github.com/trs/ftp-srv/issues/60 assigned to @trs) We should skip this test for now, what do you think?

JbIPS commented 6 years ago

We'll skip the test if we can the the issue is resolved with a real server. Can you try this branch with CE?

Thanks

JbIPS commented 6 years ago

With the latest commits, this will definitely close #127 and close #135