Skip auth for FS - Githubissues

silexlabs / unifile

Unified access to cloud storage services through a simple web API.

https://silexlabs.github.io/unifile/

MIT License

144 stars 31 forks source link

Skip auth for FS #141

Closed lexoyo closed 6 years ago

lexoyo commented 6 years ago

A question here about something very specific

In CE2, this is what happens today to enter the "fs" service:

the user clicks, I open a blank window right away (needed to avoid popup blocker of the browser)
CE2 call "/authorize" and it returns no URL
I close the window and continue

Do you want me to add a "skipAuth" attribute to the services info so that we know from the start that it is not needed?

lexoyo commented 6 years ago

Oh even better: the services should add a "isLoggedIn" to their info so that when the user is already logged in, the cloud service (github or dropbox) is not even called, no oauth. And it would be always true for fs

lexoyo commented 6 years ago

In fact, this is what I would expect in the response to '/services' https://github.com/silexlabs/unifile/blob/master/lib/unifile-github.js#L138

lexoyo commented 6 years ago

Ok, so let's recap, help wanted @JbIPS

I did this to close the popup afterwards when there is no auth URL returned by "/authorize" https://github.com/silexlabs/CloudExplorer2/pull/48/files
I have added the missing info concerning each service here, is this the way to go? If it is we can close this issue https://github.com/silexlabs/CloudExplorer2/pull/50
now we would need to do this: Do not re-auth when the user is already logged in https://github.com/silexlabs/CloudExplorer2/issues/49

JbIPS commented 6 years ago

Is there still an issue with Unifile?

lexoyo commented 6 years ago

probably not unless you think isLoggedIn should be part of the result of getInfo?

JbIPS commented 6 years ago

It is http://projects.silexlabs.org/unifile/global.html#ConnectorInfos

lexoyo commented 6 years ago

fixed by https://github.com/silexlabs/CloudExplorer2/pull/68