search

silexlabs / unifile

Unified access to cloud storage services through a simple web API.
https://silexlabs.github.io/unifile/
MIT License
144 stars 32 forks source link

Typescript Support? #149

Open rlingineni opened 5 years ago

rlingineni commented 5 years ago

Planning on making this library typescript and as a common interface so that everything is supported. I looked at a lot of other ones, and this is the cleanest and most friendly to extend. I could do some cleaning up. I can also update to ES6 syntax with async/await - for at least a few of the ones I can do.

It wouldn't change the main repo other than the fact that you'll have a new ts folder.

Are you guys ok with that? Or should I go ahead with my own fork and develop separately. Namely looking to clean up S3 and Github - because that's what I need for my larger project for now.

JbIPS commented 5 years ago

Hello @rlingineni,

I was planning to drop Bluebird for async/await but I won't mind if you do it :smiley:. For TypeScript, do you plan on only writing the types (to import it in TS codebase) or rewrite the whole thing in TS?

For those 2 things, we need to think retro-compatibility. For ES6, we'll do a new major version. And for TS, well, that will depends on your goal!

Anyway, very excited to hear about that and I'll help you in anyway I can.

Thank you

lexoyo commented 5 years ago

:+1: for typescript types and S3 I'd use them in Silex

lexoyo commented 5 years ago

Hi @rlingineni I am 90% done with porting Silex to typescript (getting ridd of google closure, splitting silex in smaller projects) Do you need help for the typing?

rlingineni commented 5 years ago

Hey @lexoyo , I was working on a project which had this dependency, but it got abandoned. If I have time in the future, I will definitely revisit this. I'm sorry to have raised hopes here

lexoyo commented 5 years ago

No problem ! I'll tell you when I'm on it If you have time to just tell me what you think it would be great We will see

On Mar 31, 2019, 2:00 PM, at 2:00 PM, Raviteja Lingineni notifications@github.com wrote:

Hey @lexoyo , I was working on a project which had this dependency, but it got abandoned. If I have time in the future, I will definitely revisit this. I'm sorry to have raised hopes here

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/silexlabs/unifile/issues/149#issuecomment-478369769