silexphp / Silex-WebProfiler

MIT License
210 stars 61 forks source link

Problems with Symfony\Component\HttpKernel #24

Closed sdurrheimer closed 10 years ago

sdurrheimer commented 10 years ago

I recently got this error message when I update my composer dependencies.

PHP Catchable fatal error:  Argument 1 passed to Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher::setProfiler() must be an instance of Symfony\Component\HttpKernel\Debug\Profiler, instance of Symfony\Component\HttpKernel\Profiler\Profiler given, called in /Users/steve/Sites/sparkles-core.local/vendor/silex/web-profiler/Silex/Provider/WebProfilerServiceProvider.php on line 49 and defined in /Users/steve/Sites/sparkles-core.local/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php on line 67
PHP Stack trace:
PHP   1. {main}() /Users/steve/Sites/sparkles-core.local/console:0
PHP   2. require() /Users/steve/Sites/sparkles-core.local/console:16
PHP   3. Silex\Application->boot() /Users/steve/Sites/sparkles-core.local/app/console.php:23
PHP   4. Silex\Provider\HttpCacheServiceProvider->boot() /Users/steve/Sites/sparkles-core.local/vendor/silex/silex/src/Silex/Application.php:186
PHP   5. Pimple->offsetGet() /Users/steve/Sites/sparkles-core.local/vendor/silex/silex/src/Silex/Application.php:51
PHP   6. Pimple::{closure:/Users/steve/Sites/sparkles-core.local/vendor/pimple/pimple/lib/Pimple.php:122-130}() /Users/steve/Sites/sparkles-core.local/vendor/pimple/pimple/lib/Pimple.php:83
PHP   7. Pimple->{closure:/Users/steve/Sites/sparkles-core.local/vendor/pimple/pimple/lib/Pimple.php:200-202}() /Users/steve/Sites/sparkles-core.local/vendor/pimple/pimple/lib/Pimple.php:126
PHP   8. Silex\Provider\WebProfilerServiceProvider->Silex\Provider\{closure}() /Users/steve/Sites/sparkles-core.local/vendor/pimple/pimple/lib/Pimple.php:201
PHP   9. Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher->setProfiler() /Users/steve/Sites/sparkles-core.local/vendor/silex/web-profiler/Silex/Provider/WebProfilerServiceProvider.php:49

Here is my composer.json

{
    "require": {
        "php"                      : ">=5.4",
        "silex/silex"              : "~1.2",
        "symfony/form"             : "~2.3",
        "symfony/translation"      : "~2.3",
        "symfony/twig-bridge"      : "~2.3",
        "symfony/validator"        : "~2.3",
        "symfony/yaml"             : "~2.3",
        "symfony/config"           : "~2.3",
        "symfony/console"          : "~2.3",
        "symfony/security"         : "~2.3",
        "symfony/event-dispatcher" : "~2.3",
        "symfony/finder"           : "~2.3",
        "twig/twig"                : "~1.10",
        "swiftmailer/swiftmailer"  : "5.0.2",
        "monolog/monolog"          : "~1.6",
        "kriswallsmith/assetic"    : "~1.1",
        "doctrine/common"          : "~2.4",
        "doctrine/dbal"            : "~2.4",
        "twitter/bootstrap"        : "v2.3.2",
        "mheap/silex-assetic"      : "~1.0.0",
        "leafo/lessphp"            : "~0.4"
    },
    "require-dev": {
        "symfony/dom-crawler"   : "~2.3",
        "symfony/css-selector"  : "~2.3",
        "symfony/browser-kit"   : "~2.3",
        "silex/web-profiler"    : "~1.0"
    },
}
ghost commented 10 years ago

There have been changes to Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher that have removed

use Symfony\Component\HttpKernel\Profiler\Profile; use Symfony\Component\HttpKernel\Profiler\Profiler; use Symfony\Component\HttpKernel\HttpKernelInterface;

which is causing this error. Adding them back in gives you a new error though :(

romainneutron commented 10 years ago

I got the same issue. @fabpot it appears that this issue happens since this commit https://github.com/symfony/symfony/commit/9c4bc9a0ed14cb333210fa6f2af682310fe48917

fabpot commented 10 years ago

should be fixed now with symfony/symfony@f7692beec7ad44e4b48c92d9936501ac235925b6

romainneutron commented 10 years ago

I've rebuilt the Travis PR is submited (see #26) and I confirm the issue is solved, see https://travis-ci.org/romainneutron/Silex-WebProfiler/builds/13308309