search

silexphp / Silex-WebProfiler

MIT License
210 stars 61 forks source link

Support symfony 3.1 #92

Closed mvanbaak closed 8 years ago

mvanbaak commented 8 years ago

https://github.com/silexphp/Silex-WebProfiler/pull/91

mvanbaak commented 8 years ago

https://github.com/symfony/symfony/pull/17589 introduced forward/redirect tracking. But it breaks with this webprofiler. I'm not sure what the best way to solve this. For this, I left the web-profiler-bundle at 3.0.*

fabpot commented 8 years ago

@HeahDude Can you have a look at it?

mvanbaak commented 8 years ago

The PR for the symfony web-profiler-bundle introduces src/Symfony/Bundle/FrameworkBundle/DataCollector/RequestDataCollector.php, specifically the getForward() method there. It's missing if you are not using the FrameworkBundle (as is the case with silex) As soon as I update the web-profiler-bundle to 3.1 the unit tests fail because it cannot find this method (of course).

HeahDude commented 8 years ago

@mvanbaak Thank you for reporting this. I've opened https://github.com/symfony/symfony/pull/18959 that fixes it.

mvanbaak commented 8 years ago

Thank you :)