search

silexphp / Silex

[DEPRECATED -- Use Symfony instead] The PHP micro-framework based on the Symfony Components
https://silex.symfony.com
MIT License
3.58k stars 718 forks source link

update minimum required php version #1063

Closed henrikbjorn closed 9 years ago

henrikbjorn commented 9 years ago

Since Symfony is going in this direction for 3.0 i think we should already consider this for 2.0 and since the development of 2.0 is running long we could also get a cleanup in.

I propose a raise to 5.4 and higher.

what do others think?

devsdmf commented 9 years ago

+1

tchalvak commented 9 years ago

What requires it?

henrikbjorn commented 9 years ago

@tchalvak there are a lot of call_user_func that could proberly be changed and increase performance. Also we could add callable typehints instead of checking with is_callable.

futurevision commented 9 years ago

+1

fbourigault commented 9 years ago

Why not require 5.5+ like symfony ? dependencies will ask to have 5.5+ so Silex minimum php version should be 5.5 to allow use of 5.5 features if wanted.

henrikbjorn commented 9 years ago

@fbourigault only from 3.0+

fbourigault commented 9 years ago

@henrikbjorn humm I misunderstood which version of Symfony Silex 2.0 will be targeting !

alcohol commented 9 years ago

Considering 5.4 is already down to a minimum of security updates only, I'd say 5.5 is a pretty decent choice. On the other hand, 5.4 would already bring sufficient room for improvement.

http://php.net/supported-versions.php

praswicaksono commented 9 years ago

5.5 would be nice

fabpot commented 9 years ago

just raised the min version of PHP to 5.5+

mediamonks-robert commented 9 years ago

Why set it to 5.5+ while the components relied on (Symfony 2.x) do not require this? Since lots of hosting environments do not support 5.5 yet but do support 5.4 I will have to migrate back from 2.x to 1.x again for upcoming projects. I would have thought that Symfony 3.x would have its own Silex 3.x with matching requirements.

henrikbjorn commented 9 years ago

@mediamonks-robert Silex and Symfony does not follow the same release cycles.

mediamonks-robert commented 9 years ago

It would be nice if it did. Now 1.x is requiring 5.3 and 2.x is directly going for 5.5 while it was 5.4 for as long as it was out there. Because I was assuming it would be 5.4 this will give a lot of issues for our projects which use Silex 2.x for a while now. Now I would need to fall back again to Silex 1.x because of a lack of a clear road map about versions.

henrikbjorn commented 9 years ago

@mediamonks-robert the roadmap have been unclear since the start of the 2.0 branch. Im sorry to sound like a douche. But you made a choice to use a development version of a library, and this is some of the things you gotta live with.

mediamonks-robert commented 9 years ago

I am aware of that but this makes it very clear that not having a clear roadmap can give issues for end users. 2.x was a good step forward but now it's a step too far for most hosting environments. I am not sure why 5.5 is needed for Silex right now as all components it is relying on are 5.4+ and no 5.5+ features are used. It was 5.4+ for ages and suddenly that changed without any given reason, it just seems like a hasty deciscion without a real reason right now.

henrikbjorn commented 9 years ago

@mediamonks-robert 5.6 is the last stable and 7.0 will be out later this year. There is no reason not to use supported and developed versions.

http://php.net/supported-versions.php shows that 5.4 only receives security fixes on a case per case basis.

Also there is no "real" 2.x you are talking about master, which is a moving target.

mediamonks-robert commented 9 years ago

I totally agree on the PHP version, it's just that a lot of big corporations won't deliver 5.5 just yet (which is a shame). I guess I'm annoyed by the fact that no roadmap is available, I made some assumptions and suddenly it changes a lot without any reason given :)

henrikbjorn commented 9 years ago

@mediamonks-robert which huge corporations? other than maybe shared hosts. 5.5 is even the default you get in the latest ubuntu LTS release (14.04)

mediamonks-robert commented 9 years ago

A lot of clients we work for, big brands who handle their own hosting or have it done for them. I am happy they just migrated to 5.4. But nevermind, it's my mistake to make assumption on Silex 2.x progress. I guess I'll have to migrate back to 1.x branch again and rewrite some custom modules. Hopefully next time a roadmap would be really nice to have to prevent such stuff.