search

silicann / blickwerk-boot

linux kernel and u-boot sources for blickwerk sensors
0 stars 3 forks source link

restore vanilla imx28.dtsi and clean-up urwerk.dtsi #11

Closed dangowrt closed 4 years ago

dangowrt commented 5 years ago

Instead of patching imx28.dtsi, rather add pinctrl nodes in urwerk.dtsi be referencing the pinctrl node. While at it, also let all other nodes in urwerk.dtsi reference existing nodes in imx28.dtsi using their names instead of their bus addresses for the sake of better readability, less redundancy, ... Further move the identical memory node from urwerk-*.dts into urwerk.dtsi and remove some duplicate nodes already present in imx28.dtsi from urwerk.dtsi.

kmohrf commented 4 years ago

Could you extend the commit message so that it reflects why you’ve made these changes? You basically do that here, but we’d rather have this kind of information in the commits than on a commercial platform. Also shame on us for not doing that in the past. We try to get better at writing useful commit messages ourselves :).

kmohrf commented 4 years ago

Apart from that this looks good to me. Do you have anything to add @sumpfralle?

dangowrt commented 4 years ago

I have copied the PR description to the commit message. Also thought about folding the patch into the existing patches, so they stop even touching (and then later restoring) imx28.dtsi.