search

siliconlad / aish

A terminal shell built with AI at the core
6 stars 0 forks source link

Refactor tokenize #87

Closed siliconlad closed 1 month ago

siliconlad commented 2 months ago

I think there's a lot of scope to improve parse. So I'm going to explore that a bit (hence why this PR is a draft).

I'm open to any suggestions on the best way of doing so.

siliconlad commented 1 month ago

The lex method is easier to understand now I think at the expense of being more verbose.

siliconlad commented 1 month ago

I think this ready for another look :)

CraigNewlands commented 1 month ago

Looks good to me, much easier to read and understand now. Might want @NiklasBurggraaff to review once more before merging

siliconlad commented 1 month ago

Will merge this so we can get on with finishing up some other features. Can always look at it again afterwards if we can think of ways to improve it all (there's probably many ways).