silinternational / ssp-base

Base Docker image for simpleSAMLphp
3 stars 1 forks source link

whitespace cleanup #240

Closed briskt closed 2 months ago

briskt commented 2 months ago

Changed

mtompset commented 2 months ago

Most of my comments are likely related to: "When the argument list is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them." (https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments) "When you have a return type declaration present, there MUST be one space after the colon followed by the type declaration. The colon and declaration MUST be on the same line as the argument list closing parenthesis with no spaces between the two characters. ... ): string {"

briskt commented 2 months ago

Most of my comments are likely related to: "When the argument list is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them." (https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments) "When you have a return type declaration present, there MUST be one space after the colon followed by the type declaration. The colon and declaration MUST be on the same line as the argument list closing parenthesis with no spaces between the two characters. ... ): string {"

Thanks for bringing this to my attention. I naively assumed that the default phpStorm settings would be PSR-12 compliant.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud