combine actions-services and docker-compose config

silinternational / ssp-base

Base Docker image for simpleSAMLphp

3 stars 1 forks source link

combine actions-services and docker-compose config #242

Closed briskt closed 2 months ago

briskt commented 2 months ago

Changed

Merged actions-services.yml into docker-compose.yml
Removed 8084 port assignment from pwmanager container to bypass an unexpected conflict. (This container is not used in manual testing and does not need a local port.)

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

briskt commented 2 months ago

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

hobbitronics commented 2 months ago

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

Yeah, I was just wondering why you were able to do that.

briskt commented 2 months ago

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

Yeah, I was just wondering why you were able to do that.

Ah, yes, good question. I'm not 100% sure, but it may have to do with some of the tests having been disabled. If a problem surfaces at the time I reenable those tests, I'm sure there's a good solution.