search

silinternational / ssp-base

Base Docker image for simpleSAMLphp
3 stars 1 forks source link

simplify sildisco integration tests, removing equivalent scenarios #270

Closed briskt closed 1 month ago

briskt commented 1 month ago

Changed

briskt commented 1 month ago

In case it helps, here are the notes I took to find which tests are equivalent:


(I) = IDPList in sp-remote.php
(S) = SPList in idp-remote.php

      |  SP1  |  SP2  |  SP3  |
IDP1  |   IS  |    S  |   IS  |
IDP2  |   IS  |   IS  |   I   |
IDP3  |   I   |       |   I   | (no SPList)

1. Sp1Idp1Sp2Idp2Sp3.feature
  a. SP1 via IDP1 ... disco AND login
  b. SP1 via IDP1 then SP2 via IDP2 ... NO disco, login required ... only 1 IdP
  c. SP1 via IDP1 then SP3 via IDP1 ... disco, NO login ... pre-authenticated
  d. IDP1 logout
  e. IDP2 logout (**DUPLICATE** of 1d**)

2. Sp1Idp2Sp2Sp3Idp1.feature
  a. SP1 via IDP2 ... disco AND login (**DUPLICATE of 1a**)
  b. SP1 via IDP2 then SP2 via IDP2 ... NO disco, NO login ... only 1 IdP & pre-authenticated
  c. SP1 via IDP2 then SP3 via IDP1 ... disco AND login

3. Sp2Idp2Sp1Idp1Sp3.feature
  a. SP2 via IDP2 ... NO disco, login ... only 1 IdP (**similar to 1b**, 1st vs 2nd SP)
  b. SP2 via IDP2 then SP1 via IDP1 ... disco AND login (**DUPLICATE of 2c**)
  c. SP2 via IDP2 then SP3 via IDP1 ... disco AND login (**DUPLICATE of 2c**)

4. Sp2Idp2Sp1Idp2Sp3.feature
  a. SP2 via IDP2 ... NO disco, login (**DUPLICATE of 3a**)
  b. SP2 via IDP2 then SP1 via IDP2 ... disco, NO login (**DUPLICATE of 1c**)
  c. SP2 via IDP2 then SP3 via IDP1 ... disco AND login (**DUPLICATE of 2c**)

5. Sp3Idp1Sp1Idp1Sp2Idp2.feature
  a. SP3 via IDP1 ... disco AND login (**similar to 1a**, IDP3 is 2nd IDP and has no SPList)
  b. SP3 via IDP1 then SP1 via IDP1 ... disco NO login (**DUPLICATE of 1c**)
  c. SP3 via IDP1 then SP2 via IDP2 ... NO disco, login (**DUPLICATE of 1b**)
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud