silkapp / rest

Packages for defining APIs, running them, generating client code and documentation.
http://silkapp.github.io/rest
390 stars 52 forks source link

Misleading documentation at fileO #130

Closed ryskajakub closed 9 years ago

ryskajakub commented 9 years ago

It would be nice to correct / make clearer the documentation on this line:

https://github.com/silkapp/rest/blob/4eefbf539185b73bc441924876c6cf1b2800602e/rest-core/src/Rest/Dictionary/Combinators.hs#L148

At least I tried to put there the combination of a ByteString and "image/jpeg" with the hope that it would use the latter for mime/type whereas it uses it for file name.

hesselink commented 9 years ago

Thanks for reporting! That comment has been wrong for a long time...

hesselink commented 9 years ago

Released as rest-core 0.36.0.5.