silkapp / rest

Packages for defining APIs, running them, generating client code and documentation.
http://silkapp.github.io/rest
390 stars 52 forks source link

Made header comparison case insensitive when using WAI driver #72

Closed tathougies closed 9 years ago

tathougies commented 9 years ago

This fixes issue #8, using the method suggested in #71

hesselink commented 9 years ago

Thanks! I'll try to review this this week. If you haven't heard back in a week, feel free to ping me :)

bergmark commented 9 years ago

I'll add some comments on things I noticed after a quick review, I'll leave the overall things to Erik.

bergmark commented 9 years ago

Some of this is just our coding guidelines, I really should publish these soon...

bergmark commented 9 years ago

I added the ToString instance in tostring-0.2.1.

bergmark commented 9 years ago

My commit contains the fixes we mentioned, ok to merge?

hesselink commented 9 years ago

Sure, the idea is still good, so if it merges and works, go for it!