Closed tathougies closed 9 years ago
Thanks! I'll try to review this this week. If you haven't heard back in a week, feel free to ping me :)
I'll add some comments on things I noticed after a quick review, I'll leave the overall things to Erik.
Some of this is just our coding guidelines, I really should publish these soon...
I added the ToString
instance in tostring-0.2.1
.
My commit contains the fixes we mentioned, ok to merge?
Sure, the idea is still good, so if it merges and works, go for it!
This fixes issue #8, using the method suggested in #71