fix: align sendRequest parameters for browser platform

silkimen / cordova-plugin-advanced-http

Cordova / Phonegap plugin for communicating with HTTP servers. Allows for SSL pinning!

MIT License

400 stars 321 forks source link

fix: align sendRequest parameters for browser platform #437

Closed gaspachoandalus closed 3 years ago

gaspachoandalus commented 3 years ago

This PR fixes a bug on browser platform where followRedirect, responseType and reqId are not retrieved correctly. So if you expect for example a "blob" responseType, the value won't be sent to the xhr layer.

I think it is probably broken since introduction of connect and read timeout (commit 6f68aab73608d9d26543e46b5cf738d18e6929ed), where the parameters following connectTimeout are shifted by one.

silkimen commented 3 years ago

Hi @gaspachoandalus, sorry I didn't see your PR and I've implemented it myself here: https://github.com/silkimen/cordova-plugin-advanced-http/commit/b3b97306f4652e4e8e49717f7ba26987c530e8fd. Therefore, I'm closing this PR now.