search

silkimen / cordova-plugin-advanced-http

Cordova / Phonegap plugin for communicating with HTTP servers. Allows for SSL pinning!
MIT License
391 stars 313 forks source link

[Bug] Apparent bug in serializeArray() #506

Open Blasterdude opened 12 months ago

Blasterdude commented 12 months ago

Describe the bug This line appears to be incorrect: https://github.com/silkimen/cordova-plugin-advanced-http/blob/master/www/url-util.js#L73

It has the incorrect number of args and doesn't seem to make sense / match other similar lines. It currently reads:

parts.push(serializeObject(parentKey + '[]' + array[i], encode));

I believe it should be changed to:

parts.push(serializeObject(parentKey + '[]', array[i], encode));
Blasterdude commented 12 months ago

I'd like to open a PR for this but I keep getting 403s when I try to publish the branch.