search

silklabs / silk

Build IoT using JavaScript. Silk Open Source
MIT License
164 stars 29 forks source link

Bug in Silk Input API Example #11

Closed alanjames1987 closed 8 years ago

alanjames1987 commented 8 years ago

The Silk Input API example is missing some closing parentheses.

input.on('down', e => log.info('Key down event', JSON.stringify(e)); // <- has 3 opening and 2 closing
input.on('up', e => log.info('Key up event', JSON.stringify(e)); // <- has 3 opening and 2 closing

I attempted to fix this change and submit a pull request but I couldn't find where the gh-pages were generated from.

jainanshul commented 8 years ago

Thank you for reporting the issue @alanjames1987. The document is generated by running npm run build from https://github.com/silklabs/silk/tree/master/docs. All you need to do is to fix the documentation at https://github.com/silklabs/silk/blob/master/bsp-gonk/vendor/silk/silk-input/lib/index.js#L92-L93 and submit the change. The github page would be updated when the documentation is generated the next time.

alanjames1987 commented 8 years ago

Understood. I've made the change and will submit the pull request.