Closed rtroncy closed 3 years ago
Changes pushed, but not yet reconverted / uploaded:
Don't forget to update https://github.com/silknow/converter/blob/master/URI-patterns.md accordingly.
Changed the URI pattern doc.
E11: URI pattern changed. @pasqLisena : Unless it takes you, too much time, do you have a Regex pattern in mind for Strings like this (year not always at the end, sometimes in the middle etc.): "RESTAURACIÓ*" : "Cerdà Durà, Elisabet - 2010 - / Fundació Abegg Stiftung. 1992 -" (3008-en.json)?
All is possible, but what is the date here? How this will be represented? These for me are 2 different restoration events:
Do you have a longer list of example to understand if we can always split at that /
?
@pasqLisena : Thanks for having a look. Here the full query for all E11s (It's not that many).
Like this is more visible.
So, from what I see, - /
is a newline character.
When there is the information about "author" and date, it is always following this pattern (line type A):
(.+)(?: -|,|.) (\d{4})(?: \((.+)\))?
Where group 1 is the author, 2 is the year, 3 is the (optional) comment.
Whatever is not following this pattern (line type B) it is a comment on what has been done during the restoration (and should simply be attached to the event as a note).
When there are more lines type A, we should create one E11 for each of them. In these cases, in the string there isn't any line type B (so we do not need to link the comment to the right event).
@tschleider can I let you implement it?
All changes implemented, will deploy them to stage tomorrow.
Deployed to stage
See https://github.com/silknow/converter/blob/master/URI-patterns.md. I believe that the following changes should be done:
crmdig:D1_Digital_Object
: currently, the URI pattern looks like http://data.silknow.org/graph/[graph-short-name]/[ID]. Instead, the URI pattern should simply be: http://data.silknow.org/object/[UUID]ecrm:E73_Information_Object
: currently, the URI pattern looks like https://data.silknow.org/informationobject/[UUID]. Instead, the URI pattern should simply be: http://data.silknow.org/object/[UUID]. Between, what is this instance supposed to be? I do have the same question for what doesecrm:E89_Propositional_Object
represent? (looking at http://data.silknow.org/object/a8c5aa2b-9426-32e9-a632-496243adde61 and nearby does not tell me)ecrm:E9_Move
: we do not seem to have anymore any instances of this class. Is it normal?ecrm:E11_Modification
: currently, the URI pattern looks like http://data.silknow.org/modification/[UUID]. Instead, the URI pattern should simply be: http://data.silknow.org/event/[UUID]. It seems that only GARIN and Imatex are providing instances of this class. The type seems to always be "restoration". In the case of Imatex, it would be good to extract the temporal information of the restauration event.ecrm:E14_Condition_Assessment
: none of the links I have clicked are dereferencable, why? What is the purpose of those instances?ecrm:E31_Document
: why do we create instances of this class in the first place? This seems relevant only for UNIPA?