silknow / converter

SILKNOW converter that harmonizes all museum metadata records into the common SILKNOW ontology model (based on CIDOC-CRM)
Apache License 2.0
1 stars 0 forks source link

Update the URI pattern creation of a number of class instances #69

Closed rtroncy closed 3 years ago

rtroncy commented 3 years ago

See https://github.com/silknow/converter/blob/master/URI-patterns.md. I believe that the following changes should be done:

tschleider commented 3 years ago

Changes pushed, but not yet reconverted / uploaded:

rtroncy commented 3 years ago

Don't forget to update https://github.com/silknow/converter/blob/master/URI-patterns.md accordingly.

tschleider commented 3 years ago

Changed the URI pattern doc.

pasqLisena commented 3 years ago

E11: URI pattern changed. @pasqLisena : Unless it takes you, too much time, do you have a Regex pattern in mind for Strings like this (year not always at the end, sometimes in the middle etc.): "RESTAURACIÓ*" : "Cerdà Durà, Elisabet - 2010 - / Fundació Abegg Stiftung. 1992 -" (3008-en.json)?

All is possible, but what is the date here? How this will be represented? These for me are 2 different restoration events:

Do you have a longer list of example to understand if we can always split at that /?

tschleider commented 3 years ago

@pasqLisena : Thanks for having a look. Here the full query for all E11s (It's not that many).

pasqLisena commented 3 years ago

Like this is more visible.

So, from what I see, - / is a newline character. When there is the information about "author" and date, it is always following this pattern (line type A):

(.+)(?: -|,|.) (\d{4})(?: \((.+)\))?

Where group 1 is the author, 2 is the year, 3 is the (optional) comment.

Whatever is not following this pattern (line type B) it is a comment on what has been done during the restoration (and should simply be attached to the event as a note).

When there are more lines type A, we should create one E11 for each of them. In these cases, in the string there isn't any line type B (so we do not need to link the comment to the right event).

@tschleider can I let you implement it?

tschleider commented 3 years ago

All changes implemented, will deploy them to stage tomorrow.

tschleider commented 3 years ago

Deployed to stage

tschleider commented 3 years ago

Examples: