search

sillsdev / SpeechAnalyzer

SIL Speech Analyzer is a Windows program for acoustic analysis of speech sounds.
https://software.sil.org/speech-analyzer/
7 stars 3 forks source link

Add Installer for OCX Microsoft Hierarchical Flex Grid #110

Closed micahtmaclean closed 1 year ago

micahtmaclean commented 1 year ago

Adds an installer for the OCX file required for the editing formant configurations dialog.

micahtmaclean commented 1 year ago

There might be use in writing a user guide somewhere on the installer because it won't work unless you run it as administrator.

darcywong00 commented 1 year ago

Responding to @megahirt from #109

The OCX folder needs a home besides the repo root. I'm thinking DistFiles or maybe Lib. Ideas @darcywong00 ?

SpeechAnalyzer.iss should be the only file in /Install and it feels like /DistFiles is the general dumping ground for files to get included with the installer. For this PR, I recommend moving MSHFLXGD.OCX, OCXInstaller.cmd, and OCXInstaller.txt to a new folder /DistFiles/OCX/.

Then update SpeechAnalyzer.iss to include the 3 files in the [Files] section. I'm not sure how to get the installer to execute OCXInstaller.cmd though. That might take some digging...

megahirt commented 1 year ago

@darcywong00 There is a [run] section just below files where they do registration of DLLs, so I'm thinking that is where it should go. Probably don't even need the bat file and just put the command straight in there

micahtmaclean commented 1 year ago

Ah, I now understand that you meant the sections in the iss file. I believe the current commit has the file section correct, but I don't understand the syntax for the run section yet. Perhaps @darcywong00 could get that working.

darcywong00 commented 1 year ago

Maybe this SO link for the [run] section

btw, no rush on this since @megahirt will be unavailable for a few weeks.

megahirt commented 1 year ago

Maybe this SO link for the [run] section

Yeah the SO link above looks really good - nice find.

micahtmaclean commented 1 year ago

Thanks @darcywong00. I've edited the ISS file to run the script. I tested it and it successfully ran the script and registered the OCX file.

Looking at the ISS file it seems like there might be a way to do it by calling {win}\Microsoft.NET\Framework\v4.0.30319\regasm.exe to register it rather than the command prompt. Not certain what the difference is.

darcywong00 commented 1 year ago

Disregard the failing automated build. I've marked it as issue #111

micahtmaclean commented 1 year ago

I've added the comments. I think the builds have been failing for some reason, which I think will prevent a merge.

darcywong00 commented 1 year ago

I think the builds have been failing for some reason, which I think will prevent a merge.

Sorry about that. I made #111 to chase down the flaky CI builds, so I guess I can't procrastinate on resolving that :/

You've done everything you can for this PR, so I'll clean up the rest. Thanks

darcywong00 commented 1 year ago

@micahtmaclean - can you merge upstream master into your fork? That should pull in the fix from #111 that fixes the failing CI build.